Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 don't show actions if Discover app is disabled #73017

Merged
merged 3 commits into from
Jul 23, 2020
Merged

fix: 🐛 don't show actions if Discover app is disabled #73017

merged 3 commits into from
Jul 23, 2020

Conversation

streamich
Copy link
Contributor

Closes #72838

@streamich streamich requested review from a team, flash1293 and kertal July 23, 2020 09:55
@streamich streamich added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:fix review Team:AppArch v7.10.0 v7.9.1 v8.0.0 labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich requested a review from kertal July 23, 2020 11:38
kertal
kertal approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 , tested locally in Chrome by creating a role with Discover disabled, logged in with a user that has only this role. "explore underlying data" is no longer displayed.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
discoverEnhanced 27.3KB +302.0B 27.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 304445f into elastic:master Jul 23, 2020
This was referenced Jul 23, 2020
Merged
Merged
streamich added a commit that referenced this pull request Jul 24, 2020
@streamich
fix: 🐛 don't show actions if Discover app is disabled (#73017) (#73049)
ec0813c 
* fix: 🐛 don't show actions if Discover app is disabled

* style: collapse ifs
streamich added a commit that referenced this pull request Jul 24, 2020
@streamich
fix: 🐛 don't show actions if Discover app is disabled (#73017) (#73048)
1f2a56b 
* fix: 🐛 don't show actions if Discover app is disabled

* style: collapse ifs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:fix review v7.9.1 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't show "explore underlying data" action if no access to Discover
4 participants
@streamich @elasticmachine @kibanamachine @kertal